[Buildbot-devel] failed msbuild steps not halting the build?
buildbot at soundgeek.org
Thu Aug 14 14:16:57 UTC 2014
On Aug 14, 2014, at 1:09 AM, Jérôme Laheurte <jerome at jeromelaheurte.net> wrote:
> Le 13 août 2014 à 21:19, Stephen Davis <buildbot at soundgeek.org> a écrit :
>> buildbot 0.8.8
>> I have some Msbuild steps which don't seem to halt the build when they fail. According to my reading of the source, haltOnFailure = True for all ShellCommand-derived classes and I don't see it getting overridden anywhere in the Msbuild class hierarchy (possibly missed of course).
>> Is anyone familiar with those classes and knows whether or not this is somehow expected or where to look to see where things are going wrong? I'm just a user of buildbot so debugging its internals is not my forté.
> I’m pretty sure the default is False; that’s how it behaves for me and that’s what I see in the API reference (inherited from BuildStep).
Dangit, you're right. MasterShellCommand defaults to True but BuildStep defaults to False. I misread the results of my search through the sources and confused MasterShellCommand with ShellCommand.
More information about the devel