[Buildbot-devel] Do we need extra test for simple or other plugin for mq

[Dustin J. Mitchell]

Correct, and also some code in test_mq_kombu.py (if your plugin is
named 'kombu').

Dustin

On Wed, Aug 6, 2014 at 11:21 AM, Damon Wang <damon.devops at gmail.com> wrote:
> Yes, I think so, test code shoudn't rely on any specific lib.
>
> so, I need to add some in test_mq.py to let it test the plugin kombuMQ, just
> like
> we add addition item in connector, right?
>
> Thx!
> Damon
>
>
> 2014-08-06 23:17 GMT+08:00 Dustin J. Mitchell <dustin at v.igoro.us>:
>
>> The test_mq.py script contains common tests that all plugins should
>> pass.  It has a class for the simple plugin (TestSimpleMQ), and should
>> have an additional class added for any additional plugins.
>>
>> There should be a test_mq_XXX.py for each XXX plugin to unit test any
>> plugin-specific methods.  The simple plugin doesn't have any
>> plugin-specific methods, so it has nothing to test.
>>
>> Ideally, test_mq_XXX.py should be able to run even if the required
>> libraries and servers (so, libamqp and rabbitmq in yoru case) are not
>> available, while test_mq.py can skip tests when those libraries and
>> servers are not available.  As a concrete example, test_mq_amqp.py
>> would be a great place to test your formatKey method, which can be
>> tested even if libamqp is not installed.
>>
>> Dustin
>
>