[Buildbot-devel] Follow up on autopep8

[Edmund Wong]

Pierre Tardy wrote:
> Hi,
>
> I worked a little bit more on autopep8 this week end.
>
> I see that ewongbb also worked on it, this looks like duplicated work, so
> I'd like we make a decision as a community on how we continue this effort.
>
> I prepared a small google form for every voice to be heard:
> https://docs.google.com/forms/d/1aUlpcs86fpQ85ltt0dGXrvAsRPMgdqDTKBNrpoKEPBk/viewform

Hi Pierre!

The only reason why I was doing it was because this kind of work
was something that I could do (i.e. low-hanging fruit)  I don't
want to duplicate any efforts that you're doing, so please tell
me which ones I shouldn't look at.

As a relative newcomer to the codebase, I'm not sure if I'm in the right
position to say anything.  What I would say is that having it as
multiple PRs would be a lot easier to review than a humungous
PR.

> Each developer has its own coding preferences. You could tell from the code
> which developer wrote it. This leads to incoherencies in the whole
> codebase, and the newcomers does not really know which best practice to use.
>
> Some of the pep8 errors looks silly or pointless (e.g. E26x). The point is
> really to make a clear and firm decision on what to do., citing the python
> zen:

I've looked at the list and don't know if I'm in the right position
to make a judgement on which errors are 'not really errors'.  Like
for instance, during my 'foray' into W291, I came across a space
at the end of a line.  This was flagged by autopep8 as an error.
However, this space at the end of the line was within a large
quoted text.  (I'm wondering if this is considered as a false
positive.)

Anyway, I have no qualms in following what you guys decide.  I'm
still learning Python and really haven't developed any strict
style yet.

Edmund