[Buildbot-devel] Using pep8 on Buildbot source code

[Pierre Tardy]

Please make sure you tried autopep8, before spending much time doing manual
fixes.

autopep8 is amazingly working well, even for non super trivial stuff like
W601.

I quickly adapted what I use internally at work, and contribute here as a
PR:
https://github.com/buildbot/buildbot/pull/935


Pierre


On Tue, Oct 22, 2013 at 10:58 AM, Vladimir Rutsky <rutsky.vladimir at gmail.com
> wrote:

> On Tue, Oct 22, 2013 at 4:40 AM, Edmund Wong <ewongbb at pw-wspx.org> wrote:
> > Dustin J. Mitchell wrote:
> >> My worry with a lot of these is that they can be burdensome for
> >> contributors, without adding a lot of value.  So:
> >>
> >>> 145     E101 indentation contains mixed spaces and tabs
> >>> 538     E111 indentation is not a multiple of four
> >>> 891     E203 whitespace before ':'
> >>> 13      E211 whitespace before '('
> >>> 932     E251 unexpected spaces around keyword / parameter equals
> >>> 35      E502 the backslash is redundant between brackets
> >>> 78      E701 multiple statements on one line (colon)
> >>> 8       E703 statement ends with a semicolon
> >>> 79      E711 comparison to None should be 'if cond is None:'
> >>> 23      E712 comparison to False should be 'if cond is False:' or 'if
> >>> not cond:'
> >>> 15      E721 do not compare types, use 'isinstance()'
> >>> 117     W191 indentation contains tabs
> >>> 316     W291 trailing whitespace
> >>> 3       W292 no newline at end of file
> >>> 421     W293 blank line contains whitespace
> >>> 95      W391 blank line at end of file
> >>> 47      W601 .has_key() is deprecated, use 'in'
> >>> 16      W602 deprecated form of raising exception
> >>> 11      W604 backticks are deprecated, use 'repr()'
> >>
> >> These are important.
> >
> >
> > Is this for 8, 9 or both?  I'm considering working on
> > W601, but I'm seeing 68 counts (on 8). (Well, it'd be
> > a start.)
>
> This report is for master branch (so it's 8, if you address Buildbot
> version). I think for nine branch report will be almost same.
>
> >
> > Edmund
> >
> >
> ------------------------------------------------------------------------------
> > October Webinars: Code for Performance
> > Free Intel webinars can help you accelerate application performance.
> > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> > the latest Intel processors and coprocessors. See abstracts and register
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Buildbot-devel mailing list
> > Buildbot-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20131022/9f9d12ce/attachment.html>