[Buildbot-devel] Using pep8 on Buildbot source code

[Edmund Wong]

Dustin J. Mitchell wrote:
> My worry with a lot of these is that they can be burdensome for
> contributors, without adding a lot of value.  So:
>
>> 145     E101 indentation contains mixed spaces and tabs
>> 538     E111 indentation is not a multiple of four
>> 891     E203 whitespace before ':'
>> 13      E211 whitespace before '('
>> 932     E251 unexpected spaces around keyword / parameter equals
>> 35      E502 the backslash is redundant between brackets
>> 78      E701 multiple statements on one line (colon)
>> 8       E703 statement ends with a semicolon
>> 79      E711 comparison to None should be 'if cond is None:'
>> 23      E712 comparison to False should be 'if cond is False:' or 'if
>> not cond:'
>> 15      E721 do not compare types, use 'isinstance()'
>> 117     W191 indentation contains tabs
>> 316     W291 trailing whitespace
>> 3       W292 no newline at end of file
>> 421     W293 blank line contains whitespace
>> 95      W391 blank line at end of file
>> 47      W601 .has_key() is deprecated, use 'in'
>> 16      W602 deprecated form of raising exception
>> 11      W604 backticks are deprecated, use 'repr()'
>
> These are important.


Is this for 8, 9 or both?  I'm considering working on
W601, but I'm seeing 68 counts (on 8). (Well, it'd be
a start.)

Edmund