[Buildbot-devel] Is extending getChoices method of ForceSched/ChoiceStringParameter to support returning deferreds a good idea?

Greg Wolgemuth gwolgemuth at magmic.com
Thu Mar 7 22:30:34 UTC 2013


I just saw Jared Grubb's work in (
https://github.com/buildbot/buildbot/pull/641) and was immediately
interested. I have several use cases for dynamically populating lists on
the Force Build screen.

Several of my use cases involve generating these lists from data external
to BuildBot. My first thought was to alter the call chain to getChoices to
support getChoices returning a possible deferred. But I'm worried about the
context of buildForceContext in status/web/builder.py. Does this only
trigger when the user loads up the builder page itself? Would invocations
of getChoices/buildForceContext need to be parallel, to prevent page
latency from getting too high (especially when viewing the "all builders"
page)? I don't want unnecessary, expensive calls to external systems
slowing down BuildBot too much.

I'd be happy to write up a pull request for this if it sounds like a good
idea.

-

Gregory Wolgemuth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130307/4596c253/attachment.html>


More information about the devel mailing list