[Buildbot-devel] New-style source steps - why commandComplete call is missing?
tom.prince at ualberta.net
Sat Jun 15 18:59:42 UTC 2013
vasslitvinov at pisem.net writes:
> It seems that all new-style source steps (at least SVN class I tried
> to use) are not calling commandComplete() method, they directly call
> .finish() or .failed(), what's the reason for that? Old-style SVN does
> call this method...
Well, the interface between `BuildStep` and its subclasses isn't really
well defeined, unfortunately. Most steps run a single remote command run
a single command on the slave, using `LoggingBuildStep.startCommand`
- `BuildStep.runCommand` to run the command
- `LoggingBuildStep.commandComplete` (amongh other things
- `BuildStep.finish` to end the step.
The old-style source steps are among these.
On the other, the new-style source steps run multiple commnds, so can't
use `LoggingBuildStep.startCommand`, but rather call
`BuildStep.runCommand` multiple times. Given this, it doesn't really
make sense to call `LoggingBuildStep.commandComplete`, since there isn't
a single remote command that gets executed.
More information about the devel