[Buildbot-devel] graceful shutdown of ChangeSource sevices

Dustin J. Mitchell dustin at v.igoro.us
Fri Jun 7 01:40:56 UTC 2013


On Thu, Jun 6, 2013 at 1:12 AM, Jorge Gonzalez <gjorge at google.com> wrote:
> buildbot.changes.base.PollingChangeSource has a stopService() method that
> I'd expect it gets called when `buildbot stop` is invoked from the command
> line, but as far as I can tell, it's never being executed.
>
> The reason I'm asking this is because I have a subclass of
> PollingChangeSource which I'd like to shutdown gracefully when the master
> shuts down, and overriding PollingChangeSource.stopService() seems to be of
> no use. Is there a another way of doing this?

I believe this was a bug that Jared has fixed in master.  Can you
check whether it's still not called in master (or, better, the 0.8.8
branch)?

Dustin




More information about the devel mailing list