[Buildbot-devel] Running Pylint on Buildbot's source code
elmir.jagudin at axis.com
Thu Jul 11 06:24:48 UTC 2013
On 07/06/2013 04:47 PM, Dustin J. Mitchell wrote:
> On Fri, Jul 5, 2013 at 5:34 PM, Dustin J. Mitchell <dustin at v.igoro.us> wrote:
>> I'm actually fine with this kind of one-line loop, especially in
>> tests. Also, i suspect W0106 will trigger on a bare
>> `json.dumps(foo)`, which we often use in tests to verify that
>> something is JSON-able.
> In fact, most of our pylint violations are probably in the tests,
> where we do funny things in order to simulate desired circumstances
> for the tests. Is there a way to apply a more stringent set of
> requirements to the production code than to the test code?
I don't think there is any good way to do that. It is possible to
enable/disable checks locally at *.py file scope. But I don't see any
way to that at package level.
I have created a new pylintrc file:
I have disabled all messages currently reported in buildbot code, so
running 'make pylint' will not report any errors. I have alos documented
the checks that shall remain disabled and tweaked symbol names regexps
to match buildbot's style.
I plan to update that file if we decide to exapand 'don't care' list and
make a pull request once we are happy with it. Then we can start working
on fixing reported issues :P
More information about the devel