[Buildbot-devel] Running Pylint on Buildbot's source code

Dustin J. Mitchell dustin at v.igoro.us
Fri Jul 5 21:34:30 UTC 2013

On Fri, Jul 5, 2013 at 6:05 AM, Vladimir Rutsky
<rutsky.vladimir at gmail.com> wrote:
> I suggest not to ignore this one --- W0106 (expression-not-assigned) ---
> according to Elmir's log it arises in:
> 1) [p.feed(c) for c in '5:hello,5:world,']
> IMO this one better to rewrite as two line "for ... in ...:" loop;

I'm actually fine with this kind of one-line loop, especially in
tests.  Also, i suspect W0106 will trigger on a bare
`json.dumps(foo)`, which we often use in tests to verify that
something is JSON-able.


More information about the devel mailing list