[Buildbot-devel] gerrit integration

[Jason Edgecombe]

On 01/27/2013 03:38 AM, Kevin Funk wrote:
> On Saturday 26 January 2013, 23:43, Jason Edgecombe wrote:
>> On 01/26/2013 08:02 PM, Dustin J. Mitchell wrote:
>>> On Fri, Jan 25, 2013 at 2:47 PM, Jason Edgecombe
>>>
>>> <jason at rampaginggeek.com> wrote:
>>>> On 01/23/2013 09:17 PM, Dustin J. Mitchell wrote:
>>>>> Try upgrading to 0.8.7?  That bug, at least, has been fixed.
>>>>>
>>>>> Dustin
>>>> That improved things. It builds when a change is submitted to gerrit, but
>>>> the status updates aren't going to gerrit.
>>> I'm not terribly familiar with Gerrit, but I believe you need to also
>>> set up status_gerrit.py to do that?
>>>
>>> Dustin
>> I'm getting the following error while using status_gerrit.py:
>>
>>         File
>> "/usr/lib/python2.6/dist-packages/buildbot-0.8.7p1_259_g02cc94f-py2.6.egg/bu
>> ildbot/status/builder.py", line 535, in _buildFinished
>>           w.buildFinished(name, s, results)
>>         File
>> "/usr/lib/python2.6/dist-packages/buildbot-0.8.7p1_259_g02cc94f-py2.6.egg/bu
>> ildbot/status/gerrit_status.py", line 126, in buildFinished
>>           return self.buildMessage(name, [build], results)
>>       exceptions.AttributeError: GerritStatusPush instance has no
>> attribute 'buildMessage'
>>
>>
>> Thanks,
>> Jason
> A lot of things a very wrong here
>
> a) gerrit_status.py doesn't exist, just status_gerrit.py
> b) lines in the backtrace do not match in status_gerrit.py
> c) 'my' status_gerrit.py also has buildFinished() but never references
>     buildMessage().
>
> Please check your setup.
>
> Greets
>

Hmm,

That's what I get for coding while tired. I'm working with an alternate 
implementation of GerritStatusPush and I had imported the wrong file, as 
you mentioned.

I've fixed the import, but I'm still getting an error.

     --- <exception caught here> ---
       File 
"/usr/lib/python2.6/dist-packages/buildbot-0.8.7p1_259_g02cc94f-py2.6.egg/buildbot/status/builder.py", 
line 535, in _buildFinished
         w.buildFinished(name, s, results)
       File 
"/usr/lib/python2.6/dist-packages/buildbot-0.8.7p1_259_g02cc94f-py2.6.egg/buildbot/status/status_gerrit.py", 
line 96, in buildFinished
         message, verified, reviewed = self.reviewCB(builderName, build, 
result, self.reviewArg)
     exceptions.TypeError: defaultReviewCB() takes exactly 5 arguments 
(4 given)

Thanks,
Jason