[Buildbot-devel] gerrit integration

[Jason Edgecombe]

On 01/22/2013 04:31 AM, Kevin Funk wrote:
> On Monday 21 January 2013, 21:33, Jason Edgecombe wrote:
>> Hi everyone,
>>
>> I'm having trouble with the gerrit status module.  I've attached my
>> buildmaster config.
>>
>> I have two problems:
>> 1. buildbot only starts a build after the change is merged.
>> 2. the status updates don't make it back into gerrit.
>>
>> Any help is appreciated.
>>
>> Thanks,
>> Jason
> As a first hint:
>
> Did you check twistd.log what's happening?
>
> E.g. this to get any gerrit related issues:
> $ grep -i gerrit twistd.log
>
> Or this to find exceptions:
> $ grep -i except twistd.log
>
> Last but not least:
> In your config there is 'gerrithost' and 'repo', 'repo' seems to be the gerrit
> URL, but 'gerrithost' is used in GerritChangeSource - are you sure this is
> correct?
>
> Greets
>

I checked, and GerritchangeSource takes a hostname, not a repo url.

The change is triggered, but the git checkout fails.

I found this in the logs:

Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 441, in _runCallbacks
     self.result = callback(self.result, *args, **kw)
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 1014, in unwindGenerator
     return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 893, in _inlineCallbacks
     result = g.send(result)
   File "/usr/lib/python2.6/dist-packages/buildbot-0.8.7_pre2_632_ge54959e-py2.6.egg/buildbot/process/buildstep.py", line 595, in _startStep_3
     result = yield defer.maybeDeferred(self.start)
--- <exception caught here> ---
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 125, in maybeDeferred
     result = f(*args, **kw)
   File "/usr/lib/python2.6/dist-packages/buildbot-0.8.7_pre2_632_ge54959e-py2.6.egg/buildbot/steps/source/oldsource.py", line 139, in start
     Source.start(self)
   File "/usr/lib/python2.6/dist-packages/buildbot-0.8.7_pre2_632_ge54959e-py2.6.egg/buildbot/steps/source/base.py", line 220, in start
     self.startVC(branch, revision, patch)
   File "/usr/lib/python2.6/dist-packages/buildbot-0.8.7_pre2_632_ge54959e-py2.6.egg/buildbot/steps/source/oldsource.py", line 712, in startVC
     self.setProperty("gerrit_branch", self.args['gerrit_branch'])
exceptions.TypeError: setProperty() takes exactly 4 arguments (3 given)


Thanks,
Jason