[Buildbot-devel] buildslave connects briefly after graceful shutdown?

Dustin J. Mitchell dustin at v.igoro.us
Sat Jan 12 14:59:11 UTC 2013


On Wed, Jan 9, 2013 at 12:39 AM, Dan Kegel <dank at kegel.com> wrote:
> How about this - it might be less racy.
>
> the master tells the slave to shut down gracefully;
> in response, the slave calls closeReadConnection();
> the master then senses writeConnectionLost, and closes
> the socket the rest of the way.  The slave then senses writeConnectionLost,
> stops the reactor, and terminates.

That sounds good, but a bit tricky with all of the layers of PB on top.

If you can make it work, and write enough tests that we can be
confident it works back to Twisted-9.0.0, I'm game!  Otherwise, I
think this is a good approach to take for a non-PB protocol.

Dustin




More information about the devel mailing list