[Buildbot-devel] assertion error on changes/manager.py

Dustin J. Mitchell dustin at v.igoro.us
Sun Aug 11 03:54:25 UTC 2013


On Thu, Aug 8, 2013 at 7:17 PM, Jorge Gonzalez <gjorge at google.com> wrote:
> I'm not really sure. It sounds right to me but what would the implementation
> return?
> From reading the contract in object.__hash__(self) it seems to me that the
> problem was that I didn't know my change source would be used in a hashable
> collection.
> Perhaps, following the advice in that link, it'd be wise to set __hash__ =
> None to force the instances to fail at runtime. This will convey the message
> more clearly that if you want to extend this class, you must implement
> __hash__()

That sounds like a great solution - thanks for doing the background
research on that :)

Dustin




More information about the devel mailing list