[Buildbot-devel] Incorrect string formatting with properties (regression?)

[Jared Grubb]

Just to close the loop, olof found the bug and has posted a pull request to fix this:
https://github.com/buildbot/buildbot/pull/823

Jared

On Aug 6, 2013, at 19:33, Jared Grubb <jared.grubb at gmail.com> wrote:

> I think this is a bug.
> 
> I'm seeing both builddir and workdir as tuples, and I cant imagine that's intentional. I'll look into this.
> 
> Jared
> 
> On Aug 6, 2013, at 2:31, ddcc <d.c.ddcc at gmail.com> wrote:
> 
>> Jared,
>> 
>> Ahh, I missed the properties shown on that page. It seems that the change from string to tuple has occurred relatively recently; do you know of any simple ways to obtain the full path? I'm not too familiar with the properties system of Buildbot, and it seems that getRenderingFor(build) is used to get the value, so I can't just do Property('workdir')[0].
>> 
>> Dominic
>> 
>> On 06/08/2013 01:27, Jared Grubb wrote:
>>> When you look at the properties in the Build page, is 'workdir' a tuple or a string?
>>> 
>>> Jared
>>> 
>>> On Aug 5, 2013, at 9:02, ddcc <d.c.ddcc at gmail.com> wrote:
>>> 
>>>> Hello,
>>>> 
>>>> Has anyone experienced any incorrect string formatting on the lastest Git master of Buildbot? In my configuration
>>>> file, I have the following defined as a build step:
>>>> f.addStep(Configure(command=['./configure', WithProperties('--with-llvm=%(workdir)s/../llvm-3_2/build')]))
>>>> 
>>>> In previous versions such as 0.8.6p1 (Fedora), I get the expected call with:
>>>> ['./configure', "--with-llvm=/home/ddcc/slave/llvm-2_9/../llvm-2_9/build"]
>>>> 
>>>> But on the latest master, I receive the following, which screws up the build:
>>>> ['./configure', "--with-llvm=('/home/ddcc/slave/llvm-2_9',)/../llvm-2_9/build"]
>>>> 
>>>> I've tried using Interpolate instead of WithProperties, but I still experience the same behavior. Any suggestions?
>>>> 
>>>> Thanks,
>>>> 
>>>> Dominic
>>>> 
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Get your SQL database under version control now!
>>>> Version control is standard for application code, but databases havent 
>>>> caught up. So what steps can you take to put your SQL databases under 
>>>> version control? Why should you start doing it? Read more to find out.
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Buildbot-devel mailing list
>>>> Buildbot-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>>> 
>> 
>> ------------------------------------------------------------------------------
>> Get your SQL database under version control now!
>> Version control is standard for application code, but databases havent 
>> caught up. So what steps can you take to put your SQL databases under 
>> version control? Why should you start doing it? Read more to find out.
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk_______________________________________________
>> Buildbot-devel mailing list
>> Buildbot-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/buildbot-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130808/fe569f72/attachment.html>