[Buildbot-devel] Patch for issue #2504 causes regression

[ddcc]

Srinu,

I don't know of any sources that explicitly state the version format of 
Git, but if you look through the tags on the Git source tree 
(https://git.kernel.org/cgit/git/git.git/refs/tags), they all appear to 
be either a.b.c or a.b.c.d, excluding the release candidates.

Thanks,

Dominic

On 06/08/2013 05:54, Srinu P wrote:
> Hi Dominic,
>
> I made this modification. I have patch to fix this issue. Before I 
> send it can you please point me to git version number formats.
>
> Regards,
> Srinu
>
>
> On Mon, Aug 5, 2013 at 5:25 PM, ddcc <d.c.ddcc at gmail.com 
> <mailto:d.c.ddcc at gmail.com>> wrote:
>
>     Hello,
>
>     The patch for issue #2504 utilizes distutils.version.StrictVersion
>     to perform strict version checking on the installed version of git
>     to determine whether the 'branch' argument is supported or not.
>     Unfortunately, StrictVersion only supports version strings up to
>     the form 'a.b.c' and not 'a.b.c.d' (see
>     http://epydoc.sourceforge.net/stdlib/distutils.version.StrictVersion-class.html).
>     On my machine, 'git --version' returns 'git version 1.8.1.4',
>     which causes an exception:
>
>        File "/home/ddcc/src/master/buildbot/steps/source/git.py", line 514, in checkSupport
>          if StrictVersion(version) < StrictVersion("1.6.5"):
>        File "/usr/lib64/python2.7/distutils/version.py", line 40, in __init__
>          self.parse(vstring)
>        File "/usr/lib64/python2.7/distutils/version.py", line 107, in parse
>          raise ValueError, "invalid version number '%s'" % vstring
>     exceptions.ValueError: invalid version number '1.8.1.4'
>
>
>     Thanks,
>
>     Dominic
>
>     ------------------------------------------------------------------------------
>     Get your SQL database under version control now!
>     Version control is standard for application code, but databases havent
>     caught up. So what steps can you take to put your SQL databases under
>     version control? Why should you start doing it? Read more to find out.
>     http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>     _______________________________________________
>     Buildbot-devel mailing list
>     Buildbot-devel at lists.sourceforge.net
>     <mailto:Buildbot-devel at lists.sourceforge.net>
>     https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130806/32c4a287/attachment.html>