[Buildbot-devel] Patch for issue #2504 causes regression

[ddcc]

Hello,

The patch for issue #2504 utilizes distutils.version.StrictVersion to 
perform strict version checking on the installed version of git to 
determine whether the 'branch' argument is supported or not. 
Unfortunately, StrictVersion only supports version strings up to the 
form 'a.b.c' and not 'a.b.c.d' (see 
http://epydoc.sourceforge.net/stdlib/distutils.version.StrictVersion-class.html). 
On my machine, 'git --version' returns 'git version 1.8.1.4', which 
causes an exception:

   File "/home/ddcc/src/master/buildbot/steps/source/git.py", line 514, in checkSupport
     if StrictVersion(version) < StrictVersion("1.6.5"):
   File "/usr/lib64/python2.7/distutils/version.py", line 40, in __init__
     self.parse(vstring)
   File "/usr/lib64/python2.7/distutils/version.py", line 107, in parse
     raise ValueError, "invalid version number '%s'" % vstring
exceptions.ValueError: invalid version number '1.8.1.4'


Thanks,

Dominic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130805/eb73721b/attachment.html>