[Buildbot-devel] bzr_buildbot.py not working

[Georges Racinet]

Le 27/09/2012 22:01, David Engster a écrit :
> Dustin J. Mitchell writes:
>> On Wed, Sep 12, 2012 at 12:37 PM, David Engster<deng at randomsample.de>  wrote:
>>>> In this case, the problem is that revision must be a string.  Can you
>>>> try this fix?
>>> I made sure I deleted the .pyc and double-checked that I had the patched
>>> version in .bazaar/plugins, but I'm afraid it still fails with the exact
>>> same error.
>> Hm, I'm not sure what to try, then.
>>
>> Perhaps, keep tracking http://trac.buildbot.net/ticket/708 and try out
>> the new work when it's available?
> After looking into my .bzr.log I saw that the revision was still send as
> an integer. So I took a chance and simply changed the *other* assignment
> of change['revision'] in line 165 to
>
>    change['revision'] = str(new_revno)

Gosh, there were two of them ? I didn't see that.
Well done, and sorry, I've been a bit stalled, could'nt take a look yet.
>
> and now it works.
>
> Still, I'm at a loss why sending the revision as a number stopped
> working in the first place, because I can see in my .bzr.log that this
> used to work just fine.
There's a recent change related to codebases with backwards 
compatibility explicitely checking for str to detect older idioms.
I've come accross it this week while upgrading a buildmaster to 0.8.7 
and had to cast to str too. I must have been lucky, 'cause it worked 
right away. That buildmaster was actually ahead of 0.8.6p1 already.

Regards,