[Buildbot-devel] sourcedirIsUpdatable function under Windows

[Esther Baruk]

Hi,

I am running Buildbot 8.0.7p1. The master is running on Cygwin, using 
SVN as a version control system. I have two slave, one under Cygwin (on 
the same machine as the master) and one under Linux.
I encountered the following issue: for the Cygwin slave, the directory 
where the svn checkout was done was not updated every time a build was 
performed. Instead, the directory was removed and another checkout was done.
After searching for a little while, it appearsthat the function 
sourcedirIsUpdatable (located in master/buildbot/steps/source/svn.py) 
always returned false.
Looking at the code of this function, the command "stat" is called on a 
value which is : {'file': self.workdir + '/.svn', 'logEnviron': 
self.logEnviron,}.
This doesn't seemcorrect to me, as the separator under Cygwin is "\". I 
think the 'file' attribute should be : self.workdir + os.sep + '.svn', 
is that correct ?

Thanks,

Esther Baruk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20121128/5338f60b/attachment.html>