[Buildbot-devel] Upgrade from 7.x to 8.x and mysql database

[Andy Salnikov]

Hi Dustin,

On 11/21/2012 10:16 AM, Dustin J. Mitchell wrote:
> On Tue, Nov 20, 2012 at 2:11 AM, Andy Salnikov <a_salnikov at yahoo.com> wrote:
>> Hi all,
>> I am trying to upgrade our system from 7.12 to 8.7 and there is on minor
>> issue that I want to understand related to changes.
> Neither of those have been released yet!  I assume you mean 0.7.12 and 0.8.7 ;)
You are right, I may be from the future but not from 3013, may be just 
couple of seconds
ahead  :
> I'm not sure why this would happen.  If you ran the upgrade a few
> times, it's possible it got run once against sqlite, then *again*
> (after changes.pck was moved) against  mysql.
>
Looking at the code I think I know why this happens. All our builds from 
the past are
manually-requested builds which were triggered by "buildbot sendchange" 
and not
by repository change. Due to this their "changes" lack some info like 
revision number.
The code which populates database OTOH seems to require revision number 
to be
present in every change, here is the code from 
db/migrate/versions/001_initial.py:

     # insert the changes
     for c in source.changes:
         if not c.revision:
             continue
         ...

So our changes do not have any chance to pass that selection. Out of 
curiosity
I commented out that "if not c.revision: continue" and re-ran upgrade again.
With this change all our old changes now appear in the database an on web
status. I do not see any problem due to missing revision number in our 
changes.
Is the revision number really necessary? What will happen in version 0.8.7
if I use the same "sendchange" command and do not provide revision number
for it?

Thanks,
Andy