[Buildbot-devel] environment during source steps

[Jorge Gonzalez]

Bumping this old thread up.
Tom, would you like me to at least extend this fix on the rest of
the slave-side steps at least?

Jorge.

Jorge


On Sun, Aug 26, 2012 at 12:27 AM, Jorge Gonzalez <gjorge at google.com> wrote:

> I understand your preference and agree with the rationale.
> I currently don't have the time to port the Repo step to a master-side
> implementation, but would be happy to complete the current change to make
> the rest of the slave-side steps aware of the env passed in.
>
> I think it's a worthwhile adjustment since it makes the slave-side steps
> consistent with their master-side ones. Particularly because
> buildbot.steps.source.oldsource.Source is already accepting an env
> dictionary and sending it over to the slave, where the fact that it's being
> ignored seems more like an accidental rather than a deliberate omission.
>
> Jorge
>
>
>
> On Sat, Aug 25, 2012 at 11:04 PM, Tom Prince <tom.prince at ualberta.net>wrote:
>
>> Jorge Gonzalez <gjorge at google.com> writes:
>>
>> > The latest documentation [1] claims that source steps take an 'env'
>> > argument whose contents should be added to child commands' environment.
>>
>> The documentation you are pointing to is only for the new master-side
>> steps.
>>
>> The slave side steps are documented at:
>>
>> http://buildbot.net/buildbot/docs/latest/full.html#source-checkout-slave-side
>>
>>
>> > I just uploaded a partial change [2] that adjusts this just for the Repo
>> > step.
>>
>> While I'd be willing to accept changes to the slave-side steps that
>> don't have master-side counterparts, I'd much prefer to see master-side
>> steps created for any vcs that people are actively using.
>>
>> The most significant reason for this, (given a new enough slave that it
>> supports the master-side steps), fixes to the source steps like this can
>> be done simply by upgrading the master, without require changes to the
>> (often many more) slaves.
>>
>>   Tom
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20121108/1b96699c/attachment.html>