[Buildbot-devel] Have 'nextSlave' to query lock status

[Jared Grubb]

On 1 Mar 2012, at 11:51, "Dustin J. Mitchell" <dustin at v.igoro.us> wrote:
> On Thu, Mar 1, 2012 at 11:51 AM, Jared Grubb <jared.grubb at gmail.com> wrote:
>> It sounds like it will work, but I am concerned that, if all slaves fail the lock-test and nextSlave returns None, there is some corner case where nothing will trigger a new test later. What triggers these maybe-run-build checks? Is it pretty much any action like another build finishing? I've been trying to find this in the code and havent yet found it.
> 
> That's all of the things that call maybeStartBuild.  If I recall, Dan
> Locks pointed out a bug where a released lock does not automatically
> retry build scheduling, and that has been fixed.

Is using knowledge of locks to select a slave something I should file a trac issue for? I am going to take a stab at it locally, so I might be able to build a patch if youre interested.

Jared