[Buildbot-devel] BuildStep tangle [Was: Easy question]

[Tom Prince]

On Wed, 15 Feb 2012 00:20:42 -0800, Ian Zimmerman <itz at buug.org> wrote:
> It seems to me that underlying all the confusion and inelegance is the
> use of the kwargs member as a kitchen sink.  Why do for example
> parameters for RemoteShellCommand have to be flattened into the
> ShellCommand's kwargs?  If they were passed as a separate dictionary
> (ie. a _single_ argument for ShellCommand), there would be no need for
> the params mechanism in this case.  Maybe something similar is true for
> all step classes?

Well, I think part of this particular instance is that
RemoteShellCommand is/should be simply an implementation detail of
ShellCommand, and seprating out the arguments to it breaks the abstaction.