[Buildbot-devel] Easy question

[Axel Hecht]

I never understood the "let's make a buildstep instance part of a factory"
theory.

Using the buildstep class and it's constructor arguments to me is the
obvious choice.

Axel

2012/1/31 Dustin J. Mitchell <dustin at v.igoro.us>

> 2012/1/31 Benoît Allard <benoit at aeteurope.nl>:
> > Keeping an eye on backward compatibility, could you elaborate on the
> > above ? We might have a winner there !
>
> We don't want to break existing custom steps or configs.  We can't use
> any Python magic, because this is about the simplest kind of magic,
> and it's causing confusion.  So either configs will need to change (we
> could go back to the old f.addStep(classname, (arguments,..)) format),
> or class implementations will need to change (so every custom class
> becomes two classes - a step factory and a step).
>
> I think the best way forward up with a new, well-documented way to
> write buildsteps that *does* involve two classes, and just let the old
> way of doing so (with factory and step in the same class) die out of
> its own accord.
>
> I'm not convinced that's any less confusing for newcomers to Buildbot,
> but I think we'd need to see a proof of concept to find out.
>
> If either of you (or someone else, of course!) would like to come up
> with such a proof of concept, and share it with the list, I think that
> would be great.  I think that we can win with a bit of competition
> between ideas.
>
> Dustin
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120213/df86f982/attachment.html>