[Buildbot-devel] getRenderingFor

[Harry]

I was confused when analyzing the buildbot.process.properties.WithProperties
method getRenderingFor. 

 

The method WithProperties.getRenderingFor  accepts a 2nd parameter name with
name 'build'. If I set a break then the build parameter resulted to be a
Properties object. Is it possible to that sometimes a Build object and
sometimes a Propeties object is passed. Both, Build and Properties inherit
from PropertiesMixin so both have getProperties. 

In the function the "build" object is passed to the lambda subs, now I think
a Properties object will be passed.

 

Writing a class analog to WithProperties I run in the problem of not having
a build object but a properties object. Happily the properties object has a
getBuild method so I was able to fix this in the new class.

 

Up to now I do not understand the Properties pattern/design/construction
completely but in my opinion the parameter name 'build' is wrong.

 

Harry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120207/397e7184/attachment.html>