[Buildbot-devel] [buildbot] Fix default with forcesched (#502)

[Pierre Tardy]

I wonder if anybody except me is using inheritParameter.

It has proven in our config to be inefficient in term of UX, and what we
really need is a "Promote" button. e.g:
Developer wants to "promote" this try build to a merge build
ReleaseGuy wants to "promote" this build to be a release released

The implementation needs hacks at several points, so
If people agree, I would propose to mark this feature as deprecated

Pierre


On Tue, Aug 28, 2012 at 3:43 AM, Dustin J. Mitchell <
notifications at github.com> wrote:

> In master/buildbot/status/web/builder.py:
>
> > @@ -168,6 +168,29 @@ def performAction(self, req):
> >          # send the user back to the builder page
> >          defer.returnValue((path_to_builder(req, self.builder_status), msg))
> >
> > +def buildForceContextForField(req, default_props, sch, field):
> > +    pname = "%s.%s"%(sch.name, field.fullName)
> > +
> > +    default = field.default
> > +    if isinstance(field, InheritBuildParameter):
> > +        # yes, I know, its bad to overwrite the parameter attribute,
> > +        # but I dont have any other simple way of doing this atm.
> > +        field.choices = field.compatible_builds(master.status, buildername)
>
> neither master nor buildername is defined here..
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/buildbot/buildbot/pull/502/files#r1470885>.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120828/20b1a0d2/attachment.html>