[Buildbot-devel] SourceBaseCommand.sourcedatafile location

[Jorge Gonzalez]

Hi there,
I'm making use of factory workdir functions[1]. This means that the workdir
passed to build steps created by these factories, including source steps,
is subject to change at runtime depending on what the provided function
returns. As the documentation[1] suggests, this is useful to keep different
dedicated workdirs for different repositories.

Now, if the goal of the contents in SourceBaseCommand.sourcedatafile is to
provide some sort of fingerprint of the origin of the source inside some
workdir (and I can be wrong about this), wouldn't it make sense to keep
sourcedatafile within the workdir it refers to? In other words, if it's
possible for a builder's source step to check code out from different
repositories into different workdirs, wouldn't it make sense to keep
separate sourcedatafiles to identify the origin of their code in them?

Currently sourcedatafile lives under SourceBaseCommand's
self.builder.basedir. Wouldn't it make sense to have it reside
under self.builder.basedir/self.workdir?

By having a single sourcedatafile within a builder's basedir, right now a
source step might decide to clobber a (runtime) workdir_A before checking
out repository A's code into it, only because last time around it checked
out repository B's code into workdir_B... which a waste of time.

This might have been discussed before, but I couldn't find a way to search
the archives in
http://sourceforge.net/mailarchive/forum.php?forum_name=buildbot-devel

Thanks,
Jorge

[1]
http://buildbot.net/buildbot/docs/current/full.html#factory-workdir-functions
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120420/abe4c7d7/attachment.html>