[Buildbot-devel] BuildBot & Visual Studios....

[Benoît Allard]

On 9/23/2011 5:15 AM, Dustin J. Mitchell wrote:
> On Wed, Sep 21, 2011 at 6:37 AM, Dmitry Nezhevenko<dion at dion.org.ua>  wrote:
>> Dustin? What do you think about this?
>
> You're right that changing existing steps' functionality is not to be
> taken lightly, although I'm open to persuasion in specific cases.
>
> As I mentioned in #2108, I'm not at all opposed to Benoit's suggestion
> to add a query-the-registry command on the slave side, and use it
> master-side to determine necessary paths.  BRM, slave commands are
> implemented in slave/buildslave/commands, and registered in
> slave/buildslave/registry.py (not to be confused with the windows
> registry :)  There is some decent documentation of the master/slave
> communication in the Developer's section of the latest docs.  After
> that, you'd just adjust the vstudio steps to call that command, get
> the result, and then invoke the appropriate shellcommand.  dion and
> benoit have had good advice on this later in this thread.
>
> Finally, as for things being old and no longer used -- from the
> perspective of a software maintainer, the software should support the
> broadest range of things practical.  So we probably need buildsteps
> for msbuild, devenv, and vcbuild.  No one person has to write all of
> them, as long as the flexibility is built in for someone to add
> functionality later.

I looked a bit at Dimitry's step, looks like they are built on top of 
the current vstudio steps. I don't think we should replace the one with 
the others though.

We should make the current steps more configurable. Add a parameter to 
decide on which build binary should be invoked (msdev, devenv, vcbuild 
or msbuild), and then smartly build the command line based on the above 
choice from the same set of parameters looks like the best approach to me.

I also agree with Ben about not relying too much on env variables, I'd 
rather pick the installdir from the registry. Same, I rather set the 
right env variables myself than relying on vcvarsall.bat, that way 
everything is kept under buildbot's control and can be exactly replayed 
again.

Dimitry, can you send me the output of the "set" command once you ran 
vcvarsall.bat from VC9 (with both possible parameters) ? I thought I had 
it installed over there, and cannot find it ... VC9 and VC10 from 
vstudio.py needs an update on that point.

Regards,
Benoit

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4936 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://buildbot.net/pipermail/devel/attachments/20110923/ee0579d0/attachment.bin>