[Buildbot-devel] Ready for 0.8.4?

[Pierre Tardy]

Ouf, I finally managed to upgrade my test buildbot...

I needed to hack this:

diff --git a/master/buildbot/scripts/runner.py
b/master/buildbot/scripts/runner.py
index 5d4013c..9640927 100644
--- a/master/buildbot/scripts/runner.py
+++ b/master/buildbot/scripts/runner.py
@@ -483,9 +483,10 @@ def upgradeMaster(config):

     if rc == 0:
         from buildbot.db import connector
+        from buildbot.master import BuildMaster

         if not config['quiet']: print "upgrading database"
-        db = connector.DBConnector(None,
+        db = connector.DBConnector(BuildMaster(config['basedir']),
                             config['db'],
                             basedir=config['basedir'])

in order to fix this crash:

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line
387, in _continueFiring
    callable(*args, **kwargs)
  File "/buildbot/buildbot_rebase/master/buildbot/scripts/runner.py", line
35, in async
    d = defer.maybeDeferred(f, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
106, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
702, in unwindGenerator
    return _deferGenerator(f(*args, **kwargs), Deferred())
--- <exception caught here> ---
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
605, in _deferGenerator
    result = g.next()
  File "/buildbot/buildbot_rebase/master/buildbot/scripts/runner.py", line
490, in upgradeMaster
    basedir=config['basedir'])
  File "/buildbot/buildbot_rebase/master/buildbot/db/connector.py", line 48,
in __init__
    self.changes = changes.ChangesConnectorComponent(self)
  File "/buildbot/buildbot_rebase/master/buildbot/db/base.py", line 39, in
__init__
    setattr(self, method, o.get_cached_method(self))
  File "/buildbot/buildbot_rebase/master/buildbot/db/base.py", line 50, in
get_cached_method
    cache = component.db.master.caches.get_cache(self.cache_name,
exceptions.AttributeError: 'NoneType' object has no attribute 'caches'

I'm gonna publish my branch with more gerrit stuff a bit later, sending the
patch earlier in the HTH,

Pierre


On Tue, May 31, 2011 at 5:50 PM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:

> On Tue, May 31, 2011 at 10:37 AM, Pierre Tardy <tardyp at gmail.com> wrote:
> > indeed, easy_install got 0.7.1 version of migrate. Is this setup.py
> comment
> > still true?
> ..
> >         # buildbot depends on sqlalchemy internals. See
> buildbot.db.model.
> >         'sqlalchemy-migrate == 0.6',
>
> I wrote that because I was digging around in some internals that I was
> worried might change later.  I haven't looked at more recent versions,
> but things may still work - or maybe the digging-around isn't even
> required anymore?
>
> Dustin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20110531/7f214b35/attachment.html>