[Buildbot-devel] Trigger steps ignore their name parameter?

William Deegan bill at baddogconsulting.com
Mon May 23 21:58:56 UTC 2011


Greetings,

I have a step specified as such:
                 veriSteps.append(Trigger(schedulerNames = sch,
                                      # display which test trigger is 
getting called for
                                      name           = '%s for test 
%s'%(sch[0],testCase),
                                      set_properties = {'release'  : 
WithProperties('%(release)s'),
                                                        'buildnr'  : 
WithProperties('%(buildnr)s'),
                                                        'jobs'     : 
'0', # read it from config file by default
                                                        'config'   : 
veriCfg,
                                                        'triggered_by' : 
name,
                                                        'testcase' : 
testCase},
                                      updateSourceStamp = True,
                                      waitForFinish     = False))

However the webstatus shows it as: "triggered TRIGGER_NAME"

Is that expected, or is that a bug?

I'm looking at the sources for the trigger step and see:

...
         def start_builds(ssid):
             dl = []
             for scheduler in triggered_schedulers:
                 sch = all_schedulers[scheduler]
                 dl.append(sch.trigger(ssid, set_props=props_to_set))
             self.step_status.setText(['triggered'] + triggered_schedulers)

             d = defer.DeferredList(dl, consumeErrors=1)
             if self.waitForFinish:
                 return d
             else:
                 # do something to handle errors
                 d.addErrback(log.err,
                         '(ignored) while invoking Triggerable schedulers:')
                 self.end(SUCCESS)
                 return None
         d.addCallback(start_builds)
...

It looks like the self.step_status.setText() is overriding the name?
Or am I misunderstanding the code?

Thanks,
Bill





More information about the devel mailing list