[Buildbot-devel] [RFC] enhancements to buildbots repo/gerrit support

[Pierre Tardy]

On Fri, Jun 17, 2011 at 4:02 AM, Charles Lepple <clepple at gmail.com> wrote:

> On Jun 16, 2011, at 2:24 PM, Pierre Tardy wrote:
>
>  Having a version of txgerrit shipped with buildbot is another thing I
>> would like to discuss. This code is adding some more dependancies to
>> buildbot, the main one being version 11 of Twisted.
>>
>
> Is it possible to not propagate the twisted-11 dependency to the rest of
> buildbot? Some distributions have been slow to upgrade Twisted (e.g. the
> most recent LTS version of Ubuntu is on 10.0.0), and it's one of the more
> complicated dependencies of buildbot to install over the system-provided
> version.
>
I got the exact the issue, and got worried, when I installed this on my prod
system.
I think the version in ubuntu 9.04 is even 8.x.0..

However "easy_install -U twisted" installed me the 11.0.0 in no time (just
had to apt-get install python-dev...)

The feature of twisted 11.0 that is needed is http.client.Agent, which is
even not powerful enough, and that I needed to subclass to add support for
proxy and keep-alive connection (and probably I will also add cookies
support to have access to gerrit's login-only features)
If twisted 11 is an issue, then maybe I can get rid of the subclassing hack,
and include a twisted 8 compatible version http.client.Agent in buildbot
(i.e. by duplicating some code from twisted 11)

Regards,
Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20110617/60874c8d/attachment.html>