[Buildbot-devel] problem with custom mail formatter

[Dustin J. Mitchell]

On Fri, Jan 14, 2011 at 7:50 PM, Amber Yust <ayust at yelp.com> wrote:
> Wait, I just saw that you had edited the write up, dustin -the original
> version is correct, hence my confusion. The reporter had used restart, and
> it hadn't picked up changes. Manually doing stop, then start, did. I've run
> into this before.

OK, I *really* want to see this replicated.

'buildbot restart' runs the stop() function (which kills the old
process) and then the start() function (which starts the new one).  So
it's the Python equivalent of 'buildbot stop && buildbot start'.

Even knowing that, I tried to replicate it with 'restart', and the new
configuration was picked up.

So, I'm going to go on the assumption that it was a reconfig (which
*does* fail to catch the changed messageFormatter - hence the bug)
until I can see config-sticking-over-restart replicated.  I suspect
that if it *is* replicated, it will turn out to be a bug in the
restart code (probably failing to shut down the old process and thus
failing to start the new).

I'm open to persuasion :)

Dustin