[Buildbot-devel] GitPoller fixes in 0.8.3p1

[Matisse Enzer]

On Jan 13, 2011, at 10:40 AM, Dustin J. Mitchell wrote:

> On Thu, Jan 13, 2011 at 12:39 PM, Matisse Enzer <menzer at apple.com> wrote:
>> So using a fully qualified path for workdir fixes the problem i saw.
>> I am also seeing this in the logs for some (not all) polling events:
> 
> I wish you'd tried this before the 0.8.3p1 release!

I agree and feel bad that I didn't make the time to try it.


> 
>> 2011-01-13 10:36:59-0800 [-] gitpoller: repo poll failed
>> 2011-01-13 10:36:59-0800 [-] Unhandled Error
>>        Traceback (most recent call last):
>>        Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: "fatal: ambiguous argument 'HEAD..FETCH_HEAD': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions\n"
> 
> That happens when the fetch fails, for whatever reason.  Amber has
> suggested that a better solution would be to use remote branches, so
> e.g., we'd log master..origin/master instead of HEAD..FETCH_HEAD.  I
> think that might improve the situation a little bit (after a failed
> fetch, you'd just get zero revisions).

OK - I'll see if I can add some code to show me why the fetch is failing.
I admit I am considering switching to post-receive hooks instead of polling. (I have not used them because i don't like the idea that the git repo needs to know about buildbot.)

-M