[Buildbot-devel] forward slash missing in the path when sending email with mailnotifier; is a bug?

Fulvio Cervone fcervone at me.com
Mon Feb 7 08:03:00 UTC 2011


Thanks for being so open,

all that I would add (in the words that you see fit the best), is that the parameter in BuildbotURL is going to be added to getURLForThing(build) (In the example for the mailsender), so when that parameter is used to get a link to the builder page you gotta keep in mind that the proper URL must also include the slash, since the builder will not add it right before concatenating the string coming from the builder with the name and build number.

Maybe adding the slash at the end of the URL it is something that everyone would know; but reading the comment on the cfg file or the manual reveals no clue about the need to add it (if you ask me for a URL i don't feel the need to add a trailing slash, while if you ask me for a path I will always add the trailing slash since it can make the difference.

Thanks!

On Feb 6, 2011, at 8:13 PM, Dustin J. Mitchell wrote:

> On Sat, Feb 5, 2011 at 1:27 AM, Brad Hards <bradh at frogmouth.net> wrote:
>> Perhaps you could submit a patch for it.
> 
> Indeed.  For documentation, I'll take any sort of patch, and will
> happily reformat it into texinfo as necessary.  Please let me know
> what should change!
> 
> Dustin
> 
> ------------------------------------------------------------------------------
> The modern datacenter depends on network connectivity to access resources
> and provide services. The best practices for maximizing a physical server's
> connectivity to a physical network are well understood - see how these
> rules translate into the virtual world? 
> http://p.sf.net/sfu/oracle-sfdevnlfb
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel





More information about the devel mailing list