[Buildbot-devel] required fields forcing a build

[Harry Borkhuis]

We have looked at the new Force-Scheduler, as there was a merging conflict
with the multi repo scheduler functionality.

Looking at the implementation of the Force-Scheduler I expect some
complication when using multi-repositories. 
The force-scheduler partly re-implements the BaseScheduler.
addBuildsetForChanges(). The only difference is that there are no changes
created. Implementing the multi-repo functionality would require to change
BaseScheduler and Force-Scheduler in almost the same way.

The best place to create multiple sourcestamps (for each repository one) is
in the BaseScheduler.addBuildsetForChanges() method. The changes from the
same repository are then grouped into a single SourceStamp. For the
remaining repositories with no changes, a sourcestamp will be created but
without changes (same as force build). 

In my opinion it would be better to have the following methods:

addBuildSetForForcedBuild(change, reason etc.):
	_addBuildSetForChanges(change=change, changeids=None, etc...)

addBuildSetForChanges(changids, reason etc....):
	_addBuildSetForChanges(change=None, changeids=changeids, etc...)

The _addBuildSetForChanges can use the single change object or can use the
changeids to handle multiple changes. The currently available method only
needs minor changes. 

Now the ForceScheduler can use all the base functionality in stead of
re-implementing the logic.

Harry 



-----Original Message-----
From: Dustin J. Mitchell [mailto:dustin at v.igoro.us] 
Sent: Monday, December 12, 2011 6:44 AM
To: Todd Cooper
Cc: buildbot-devel at lists.sourceforge.net
Subject: Re: [Buildbot-devel] required fields forcing a build

On Thu, Sep 15, 2011 at 1:05 PM, Todd Cooper <todd_cooper at yahoo.com> wrote:
> One thing at a time.. I will do the force build changes first.

Pierre's force-scheduler changes have landed, now, if you'd like to
take a look and build on them.

Dustin

----------------------------------------------------------------------------
--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
Buildbot-devel mailing list
Buildbot-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/buildbot-devel