[Buildbot-devel] base.py getAndCheckProperties

Stephan Bergmann stephan.bergmann at oracle.com
Wed Apr 6 12:18:18 UTC 2011


In buildbot-0.8.3p1/buildbot/status/web/base.py getAndCheckProperties, 
where the custom build properties from a HTTP "Force build" request are 
processed, I wonder whether there is any reason to enforce that 
property%dname and property%dvalue each match r'^[\w\.\-\/\~:]*$'.

(That bit me in a BuildBot setup where I wanted to use such a custom 
build property to specify two URIs separated by whitespace.  The build 
request was silently dropped, and twisd.log contained the "bad property" 
log.msg.)

-Stephan




More information about the devel mailing list