[Buildbot-devel] buildbot try and virtualenv

Doug Latornell djl at douglatornell.ca
Tue Sep 28 01:36:58 UTC 2010


On Tue, Sep 21, 2010 at 8:11 PM, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> If you can clean up the 'try'
> command-line support while you're in there, that would be even better
> -- I think there are a number of naming differences between config
> options and command-line options

I've taken a look at this and there are indeed some inconsistencies.
The general pattern is:
  --connect option on the command line == try_connect in the options file

The obvious cases that need to be fixed are:
  --try-topdir on cmdline == try_topdir in options; s/b --topdir on cmdline
  --try-topfile on cmdline == try_topfile in options; s/b --topfile on cmdline
  --tryhost on cmdline == try_host in options; s/b --host on cmdline

Then there is:
  --trydir on the cmdline == try_dir in options
which is used to specify the jobdir directory for the --connect=ssh
option to use. Maybe that should change to:
  --jobdir on the cmdline == try_jobdir in options

These all look like breaking changes to me. Does that mean that the
old forms need to remain but raise DeprecationWarnings, or should I
just go ahead and make changes with no regard for backward
compatibility?

Doug




More information about the devel mailing list