[Buildbot-devel] buildslave KILL=TERM then KILL

[Dustin J. Mitchell]

On Wed, Sep 1, 2010 at 11:31 AM, Jakub Gustak <jgustak at gmail.com> wrote:
> Patch in attachment. Although no unit tests for this functionality.
>
> Any suggestions how to test it? What tools to use.

I was hoping we'd see some review or comment here, but all the same,
taking a closer look, I see:

+            try: # this can be already called when TERM was unsuccesfull
+                self.timer.cancel()
+            except:
+                pass
             self.timer.cancel()

which doesn't seem to make sense.  The rest, though, looks good, so
I'll get it committed and we'll see what happens.

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com