[Buildbot-devel] Upgrade headache: when are start() and finished() called?

[Greg Ward]

On Fri, May 7, 2010 at 3:08 PM, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> There is no real "contract" - Step semantics have been defined by
> implementation, and the implementation changes.  Sorry about that :(

No worries.  IMHO there *is* a contract, but it is implicit and
defined by the code.  And it can change from version to version.
That's fine; that's exactly as much API stability as I am paying for.
;-)

> That said, this seems an odd way to implement doStepIf.  Can you file
> a bug with milestone 0.8.1 and hopefully someone can take a look at
> it?

http://buildbot.net/trac/ticket/837

What do you think of adding a BuildStep method that is guaranteed to
be called before the step runs or is skipped?  I suppose the
alternative is not to call finished() on skipped steps, but I'm sure
someone out there depends on finished() being called.

Thanks --

Greg