[Buildbot-devel] some problems with buildbot 0.8.0rc2 after upgrade from 0.7.12

[Gareth Armstrong]

Ok, I have tracked down problem 2 (Nightly scheduler not recording changes).

The following fixes the issue for me and aligns with the logic in the 
0.7.12 Nightly scheduler.

$ git diff
diff --git a/buildbot/schedulers/timed.py b/buildbot/schedulers/timed.py
index 7fc0d3b..2db4210 100644
--- a/buildbot/schedulers/timed.py
+++ b/buildbot/schedulers/timed.py
@@ -50,6 +50,13 @@ class TimedBuildMixin:
          ssid = db.get_sourcestampid(ss, t)
          self.create_buildset(ssid, self.reason, t)

+    def start_requested_build(self, t, all_changes):
+        # start a build with the requested list of changes
+        db = self.parent.db
+        ss = SourceStamp(changes=all_changes)
+        ssid = db.get_sourcestampid(ss, t)
+        self.create_buildset(ssid, self.reason, t)
+
      def update_last_build(self, t, when):
          # and record when we did it
          state = self.get_state(t)
@@ -249,7 +256,8 @@ class Nightly(base.BaseScheduler, 
base.ClassifierMixin, TimedBuildMixin):
                  log.msg("Nightly Scheduler <%s>: "
                          "skipping build - No important change" % 
self.name)
                  return
-            self.start_HEAD_build(t)
+            all_changes = important + unimportant
+            self.start_requested_build(t, all_changes)
              # retire the changes
              changeids = [c.number for c in (important + unimportant)]
              db.scheduler_retire_changes(self.schedulerid, changeids, t)

I would like some more eyes on the fix before I submit the patch.

All the best,

Gareth


On 05/04/2010 01:05 AM, Dustin J. Mitchell wrote:
> Space problem on buildbot.net is fixed - thanks!
>
> On Mon, May 3, 2010 at 5:39 PM, Armstrong, Gareth
> <gareth.armstrong at hp.com>  wrote:
>    
>> 1) "buildbot upgrade-master `pwd`" does not terminate and has to be killed manually. Is this meant to be?
>>      
> Not at all :)
>
> How long did you wait?  Any idea what it was up to?  I can't replicate this..
>
>    

I waited 5 and 10 minutes respectively on two different attempts.  I 
will try and dig digger on another spin.

-- 
-------------------------------------------------------------------------------
  Gareth ARMSTRONG
  HP Communications&  Media Solutions
  Email  : gareth.armstrong at hp.com
  Phone  : +33 (0)4.76.14.43.89
-------------------------------------------------------------------------------