[Buildbot-devel] Changing the behavior of the SVN buildstep defaultBranch argument...

[Dustin J. Mitchell]

On Fri, Mar 26, 2010 at 1:05 PM, Gareth Armstrong
<gareth.armstrong at hp.com> wrote:
> Would folks like to see this become the default, or should legacy preside?
> Thoughts and comments are more than welcome.  If feedback is positive I will
> post a patch to github.  In any case, have a good weekend

My feeling is that this "defaultBranch" business is a bad idea - it
causes confusion, and makes a lot of common configurations difficult.
IMHO, a source step should just build the source stamp it was given --
not try to take pieces of that source stamp and invent other pieces.

We now have source stamps specifying the source code completely:
repository, project, branch, revision.  Sure, branch can be None, in
which case you need to supply a default (this was a design mistake,
IMHO).  And revision can be None, which means "latest" (this is very
useful).

So I think that if we're going to change existing behavior, it should
be in the direction of just building what you're told, rather than
(and am I reading this right?!) making the defaultBranch *override*
the branch in the SourceStamp.

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com