[Buildbot-devel] Projects, repositories and revisions

Marcus Lindblom macke at yar.nu
Mon Mar 22 10:18:29 UTC 2010


Hi,

Last weekend I started to modify the revlink/changecommentlink args to 
WebStatus so that revisions from different repos would work better (and 
similar, issue/bug/ticket links for different projects).

This is quite easy to do when viewing Change objects, as everything is 
stored nicely there. (So, we can pass in strings/tuples as before, or 
dicts of strings/tuples, or callables. All this works nicely now, and 
there's some new unit tests as well .. ;)

However, the build objects (used by grid/console/waterfall/etc) do not 
seem to store the Change itself, only the revision (i.e. the 
got_revision property). This makes it hard to figure out what repository 
a given revision belongs to.

If I'm right (I might not be, it's known to happen... ;) this makes it 
rather more difficult to implement this properly througout webstatus.

So, any ideas on how to get the repository id (as sent in by the Change) 
from a build?

It seems as if it be the responsibility of the SourceStep to store that 
data in the build. (Especially if we do 'force build', since there's no 
Change object that triggers the build then. There could also be several 
Changes, not all from the same repo, so I'm reluctant to look at those..)

Cheers,
/Marcus






More information about the devel mailing list