[Buildbot-devel] Problems with VC8 step

[Giuseppe Corbelli]

On 23/07/2010 11:06, Benoît Allard wrote:
>>> Assertion does NOT fail (as expected) but the behaviour is wrong, as
>>> stated in previous message.
>>
>> Ben, Giuseppe, will you be able to invent a fix for this between the
>> two of you?
> 
> I'm not having much free time at the moment to look into this.
> 
> The actual trouble is that the parameters are not propagated from the
> Step definition to the actual step code.
> 
> I bet Guiseppe, if you have time to, you best chance is to look with
> your original script at all the intermediate steps, where actually are
> all the parameters dropped, and look at another BuildStep implementation
> to see what's missing in the VisualStudio steps to propagate the
> parameters ...
> 
> I can try to give you hints or pointers if you send your intermediate
> results.

Seems that there's a missing call to addFactoryArguments() that in turn seems
to save the parameters.
I don't really know, but by adding this call the stuff began to work (just a
couple of tests made).

Please see:
http://buildbot.net/trac/ticket/929

with a patch attached.

-- 
        Giuseppe "Cowo" Corbelli ~\/~ My software: http://cowo.yoda2000.net
-<! Non c'e' niente da dire in proposito. Tutto quello che uno deve fare e'
  colpire i tasti giusti al momento giusto, e lo strumento suona da solo. !>-
                                J.S. Bach