[Buildbot-devel] Problems with VC8 step

[Giuseppe Corbelli]

On 22/07/2010 10:26, Benoît Allard wrote:
> Looks like the parameter of the step got lost somewhere.
> 
> Turns out I use the step a bit differently like that:
> 
> steps = [
>     factory.s(SVN, svnurl=svnurl),
>     factory.s(VC8,
>        mode = "rebuild",
>        projectfile = "msvc/solution.sln",
>        config = "Release",
>        installdir = "msvc_base_installation",
>        useenv = False,
>        arch = "x86"),
> ]

Most interesting.

s2 = factory.s(
  VC8,
  mode = "rebuild",
  projectfile = "msvc/libCopan-C++.sln",
  config = "Release",
  installdir = master_environment.msvc_installdir,
  useenv = False,
  arch = "x86"
)
myfactory.addStep(s2)

When I launch master here's what I get in the log:

  File "c:\Devel\Buildmaster\CopanProjects.py", line 84, in __init__
    myfactory.addStep(s2)
  File "C:\Program
Files\ActivePython2.6\lib\site-packages\buildbot\process\factory.py", line 67,
in addStep
    raise ValueError('%r is not a BuildStep nor BuildStep subclass' %
step_or_factory)
exceptions.TypeError: not all arguments converted during string formatting

First of all there's a bug in the ValueError raise. Can't see why this is
happening, though.
Turns out that the check
if isinstance(step_or_factory, BuildStep):
fails.

Did some more digging.
If I do:

s2 = factory.s(
  VC8,
  mode = "rebuild",
  projectfile = "msvc/libCopan-C++.sln",
  config = "Release",
  installdir = master_environment.msvc_installdir,
  useenv = False,
  arch = "x86"
)
assert(isinstance(s2, BuildStep))

Assertion FAILS (again, can't see why).

If I do:

s2 = VC8
    mode = "rebuild",
    projectfile = "msvc/libCopan-C++.sln",
    config = "Release",
    installdir = master_environment.msvc_installdir,
    useenv = False,
    arch = "x86"
)
assert(isinstance(s2, BuildStep))

Assertion does NOT fail (as expected) but the behaviour is wrong, as stated in
previous message.

-- 
        Giuseppe "Cowo" Corbelli ~\/~ My software: http://cowo.yoda2000.net
-<! Non c'e' niente da dire in proposito. Tutto quello che uno deve fare e'
  colpire i tasti giusti al momento giusto, e lo strumento suona da solo. !>-
                                J.S. Bach