[Buildbot-devel] Annoying behavior for ShellCommand under Win32

[exarkun at twistedmatrix.com]

On 09:47 pm, fcrestois at hotmail.com wrote:
>
>Thanks , i didn't realize that this thread was already closed
>
>Too bad for windows buildbot user at least we know that to use DevEnv 
>command line
>
>we need to hack twisted (tested Twisted 2.4 and 8.2)
>
>  in twisted\internet\_dumbwin32proc.py  change
>
>   cmdline = quoteArguments(args)
>   by
>   cmdline = " ".join(args)
>
>or create batch file ...
>>It convinces me that there is no general, correct way to do this.
>
>yes, it's why a quoting agnostique solution aka no quoting rules is 
>better that a forced simplified rules like if " then \" 
>(cmdLineQuote(s) from twisted\python\win32.py)

Unfortunately, this is a bit optimistic.  Applying no quoting is just as 
wrong as applying the wrong quoting.

I'm not entirely convinced that there's no way for ShellCommand to work 
properly, but it is at least more complicated to figure out than I can 
manage right now (particularly considering I have no Windows machines to 
do any testing on these days).

The idea of putting commands into .bat files instead of trying to quote 
them is interesting.  If it works out, then this problem should go away 
- just by avoiding the problematic codepaths, rather than trying to 
implement different/better quoting rules.

Jean-Paul