[Buildbot-devel] Annoying behavior for ShellCommand under Win32

[fabrice fabrice]

Thanks , i didn't realize that this thread was already closed

 

Too bad for windows buildbot user at least we know that to use DevEnv command line

we need to hack twisted (tested Twisted 2.4 and 8.2)

  in twisted\internet\_dumbwin32proc.py  change

   cmdline = quoteArguments(args) 
   by
   cmdline = " ".join(args)

 

or create batch file ...


 

> It convinces me that there is no general, correct way to do this.

yes, it's why a quoting agnostique solution aka no quoting rules is better that a forced simplified rules like if " then \" (cmdLineQuote(s) from twisted\python\win32.py)

 

Thanks you again for supporting BuildBot (running continuously since 3 years) with hacked twisted :-)


 

Fabrice


 
> Date: Wed, 27 Jan 2010 15:15:32 -0600
> Subject: Re: [Buildbot-devel] Annoying behavior for ShellCommand under Win32
> From: dustin at zmanda.com
> To: fcrestois at hotmail.com
> CC: buildbot-devel at lists.sourceforge.net
> 
> We have discussed this a bit in #buildbot, and there's a summary on
> http://buildbot.net/trac/ticket/377.
> 
> Basically, I think that the most sensible thing for Buildbot to do is
> just run everything from a batch file - that puts the string to
> execute in a frame with which Windows people are very familiar (batch
> files), or at least one they can test easily without worrying about
> what buildbot/twisted are doing "under the hood".
> 
> Jean-Paul provided this link, which makes my eyes bleed:
> http://www.autohotkey.net/~deleyd/parameters/parameters.htm
> 
> It convinces me that there is no general, correct way to do this. We
> could target the quoting to the particular program we're running,
> usually cmd.exe, but it's neither clear to me that every target string
> can be successfully represented in quoted form, nor that buildbot can
> always assume it is running (the same version of) cmd.exe.
> 
> Dustin
> 
> -- 
> Open Source Storage Engineer
> http://www.zmanda.com
 		 	   		  
_________________________________________________________________
Say Happy New Year with Messenger for Mobile.
http://go.microsoft.com/?linkid=9706117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100127/49fe3799/attachment.html>