[Buildbot-devel] Annoying behavior for ShellCommand under Win32

[fabrice fabrice]

I am integrating Buildbot 7.12 with Python 2.6 and Twisted 8.2 under Windows XP
And I find the same annoying behavior than BuildBot 7.5 with Python 2.4 and Twisted 2.4
 
For windows user, It is very convenient to start directly the VisualStudio devenv command line to make a build
This command line have a parameters like “plateform|configuration”
 
If I run a simple build factory with a shell command step like
 
from buildbot.steps.shell import ShellCommand
factory.addStep(ShellCommand(command=r'echo "Win32|Release"'))
 
The stdio display the wrong result \"Win32|Release\"
 
The problem come from the function cmdLineQuote(s) from twisted\python\win32.py 
The “quoting under windows” thread is a 5 years old bug : http://twistedmatrix.com/trac/ticket/1123 
 
For twisted 2.4, I resolve the issue by “hacking”  twisted\internet\_dumbwin32proc.py
 Let the user make the correct quoting by changing
  cmdline = quoteArguments(args)
  by
  cmdline = " ".join(args)
 
For twisted 8.2 no clean correction like subprocess.Popen that give the choice by providing
  List of argument that will be automatically quoted 
  or
  Provide raw string  (that is NOT changed)
 
 
For my new integration, I like to find a cleaner solution than hacking the third party
 
Windows buildbot user, any advice ?
 
 
Fabrice
 
 
 
 
 
 
 
 
 
 
  		 	   		  
_________________________________________________________________

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100127/17af0ab9/attachment.html>