[Buildbot-devel] Revlinks (Was: Re: WebStatus ponderings)

[Marcus Lindblom]

On 2010-01-07 21:12, Marcus Lindblom wrote:
> On 2010-01-06 17:25, Dustin J. Mitchell wrote:
>> On Wed, Jan 6, 2010 at 4:14 AM, Marcus Lindblom<macke at yar.nu>   wrote:

>>> 3. Someone (myself?) should hack together a better view of all the
>>> changes that come in (they're only visible in waterfall, and there's no
>>> concise list of them anywhere). Also, the ability to link incoming
>>> changes/revisions to external web-views (hgwebdir.cgi, svnserve, viewvc,
>>> trac, etc) would be cool&   integratey (;-P).
>>
>> I think that's what the "links" attribute of a Change is for, but this
>> seems disused.  Perhaps it could be revived?
>
> The problem is how to populate it properly. It feels wrong to insert
> this in the change hook, and there are a few places here and there where
> we list a revision without a change. (i.e. when we retrieve it in from
> the SourceStep.)
>
> I like Benoit's proposal by adding a location to change. Then it would
> be up to another object to create an URL from location + change id,
> which necessarily needs user configuration. The same object would be
> used for any revisions ids the system comes up with, regardless of them
> coming from a change or not.

I've pushed the following quick solution:
   WebStatus(..., revlink="http://server/svn/%s")

(Shortening of revisions ids that was recently discussed is also in...)

W.r.t. the 'links' attribute in a change; it is respected in some places 
in the html-templates, but mostly for historical reasons (i.e. it was in 
the original code when I did the jinjafication).

The 'sendchange' doesn't support it, so it seems as if support for it 
has been pretty dead. Also, aren't changes stored in the DB/pickle? Then 
they probably shouldn't have URLs in them... IIUC.

A 'source', 'location', 'origin' or 'repo' (whatever it's called) makes 
more sense in the larger scheme of things, IMO. This makes it easier to 
move the repo or it's webview to another server and just update the 
buildbot config to make all the links point to the right place.

When we get that, we add support for a dict as revlink arg type, mapping 
repos to URLs.

Cheers,
/Marcus