[Buildbot-devel] Buildbot-0.7.12rc2 - tests error on python 2.3

[Bailey, Darragh]

> -----Original Message-----
> From: Marcus Lindblom [mailto:macke at yar.nu] 
> Sent: 11 January 2010 14:36
> To: buildbot-devel at lists.sourceforge.net
> Subject: Re: [Buildbot-devel] Buildbot-0.7.12rc2 - tests 
> error on python 2.3

<snipage>

> [many of these]
> >    File 
> "/build/user/darragh/git/buildbot/buildbot/status/web/console_
> html.py", line 1, in ?
> >      from string import Template
> > exceptions.ImportError: cannot import name Template
> 
> We could also just disable the console-view on Python 2.3, to 
> keep the 
> master compatible for this release?


The attached patch seems to fix all the issues for me. It includes a copy of the string.Template class from python 2.4 (Python license indicates that it's GPL compatible so it should be possible to take this as is), and changes some sort(key=...) functions to use lambda.

Passes all tests for me with this patch on both python 2.3 & 2.4 (with a few skips).

--
Regards,
Darragh Bailey

Systems Software Engineer
Hewlett Packard Galway Ltd.

Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-issues-with-python-2.3.patch
Type: application/octet-stream
Size: 9032 bytes
Desc: 0001-Fix-issues-with-python-2.3.patch
URL: <http://buildbot.net/pipermail/devel/attachments/20100111/b34a49a8/attachment.obj>