[Buildbot-devel] Add repository path to the Source object

[Benoît Allard]

Hi There,

Currently, the "Change" object (from buildbot.changes.changes import 
Change) has information about a changeset: at least who did it, files 
involved, and comments about it. This can be extended with a revision 
information, a date, a branch, a couple of properties, ...

A "SourceStamp" object (from buildbot.sourcestamp import SourceStamp) 
define what will be built by gathering one or more mergeable "Source".

Would it benefit to some other people to add a property about the 
repository path inside the "Source" object ? This would be making it 
completely self-defined: repository where it occured + what occured.

I can imagine this information will be needed if buildbot is going 
toward a multi-repository support, at least for information/debugging 
purpose : knowing where did the Change came from.

Then, we would just ask SourceStamp to gather the repositories path of 
the Source so that we can use it further inside buildbot for displaying 
or more. I, for instance, am using it as a property in one of my steps.

----

About the "category" support:

"Source" can have a category attribute. I have a bad feeling about that 
one as it has to be configured by hand in the config script. One example 
of usage for this feature (category) you can find in the doc  is to set 
some builder as "test".

This category has to be set via configuration, whereas this information 
(the repository path) is already self-contained in the repository 
itself, I am more in favor of using an existing property than having to 
specify it manually for each builder/source/...

I hope I made my point more clear this time.

Best Regards,
Benoît